Change signature of materialize! to fix regression on Windows
#337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
=======================================
Coverage 94.21% 94.21%
=======================================
Files 17 17
Lines 3144 3144
=======================================
Hits 2962 2962
Misses 182 182 ☔ View full report in Codecov by Sentry. |
|
I don’t think the downstream tests will check on windows but hopefully it fixes the issue |
|
Seems to have worked, all the CI timings are independent of OS |
Would it be worth putting into the downstream.yml to test? That'd make a ton of workflows I guess is a problem |
|
No it’s not worth it. I’ll just merge and tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here JuliaApproximation/SemiclassicalOrthogonalPolynomials.jl#111, this fixes the weird inlining bug/regression on Windows by changing the signature of
materialize!. Don't know if this is the best solution ideally, but it seems to work. Tests pass locally but let's see what the downstream CI says.Don't really know the best way to a test of this regression to avoid this happening again.. I guess just checking that the Windows CI times are comparable to the other OSs?